-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev containerservice microsoft.container service 2021 02 01 #12771
Merged
PhoenixHe-NV
merged 9 commits into
master
from
dev-containerservice-Microsoft.ContainerService-2021-02-01
Feb 25, 2021
Merged
Dev containerservice microsoft.container service 2021 02 01 #12771
PhoenixHe-NV
merged 9 commits into
master
from
dev-containerservice-Microsoft.ContainerService-2021-02-01
Feb 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2020-12-01 to version 2021-02-01
…ityProfile` (#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example
…ne (#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <lima2@microsoft.com>
* add azure portal fqdn * add azure portal fqdn * fix prettier
bcho
requested review from
ArcturusZhang,
ChenTanyi,
jsntcy and
msyyc
as code owners
February 2, 2021 02:42
Hi, @bcho Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
@PhoenixHe-msft could you help review this pr? We want to merge the 0201 api changes to master. Thanks! |
This was referenced Feb 2, 2021
@msyyc Python track2 failed. Could you please help to investigate? |
PhoenixHe-NV
approved these changes
Feb 2, 2021
hey @msyyc @PhoenixHe-msft any updates for this PR? Should we wait until we fix the python-track2 pipeline failure? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Feb 25, 2021
/azp run |
26 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
) * Adds base for updating Microsoft.ContainerService from version stable/2020-12-01 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * aks: generate 2021-02-01 sdk (Azure#12311) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` (Azure#12309) * aks: add `allowNetworkPluginKubenet` field to `ManagedClusterPodIdentityProfile` * aks: add pod identity example * AKS: add fqdnSubdomain for private cluster with custom private dns zone (Azure#12361) * add fqdnSubdomain for private cluster with custom private dns zone * add example ref * fix example Co-authored-by: Li Ma <lima2@microsoft.com> * add new disk choice (Azure#12682) * AKS: Add Node Public IP Prefix support. (Azure#12673) * Add azure portal fqdn (Azure#12725) * add azure portal fqdn * add azure portal fqdn * fix prettier Co-authored-by: Super <mali_no2@hotmail.com> Co-authored-by: Li Ma <lima2@microsoft.com> Co-authored-by: Ace Eldeib <alexeldeib@gmail.com> Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com> Co-authored-by: tilnl <44656553+tilnl@users.noreply.github.com>
FumingZhang
deleted the
dev-containerservice-Microsoft.ContainerService-2021-02-01
branch
February 26, 2024 05:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
We want to publish new api version 2021-02-01 for AKS.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.